Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid building unnecessary ABIs in test fixture #1208

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

fractalwrench
Copy link
Contributor

Goal

Reduces the size of the mazerunner test fixture by excluding the x86_64 and armeabi_v7a architectures. We don't actively test with these so excluding them makes sense to decrease the time spent waiting for APKs to upload.

This is based on the approach taken in the following Android PR: bugsnag/bugsnag-android#1054

@fractalwrench fractalwrench changed the title test: avoid building unnecessary ABIs in test fixture Avoid building unnecessary ABIs in test fixture Dec 16, 2020
@bugsnagbot
Copy link
Collaborator

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.70 kB 12.54 kB
After 40.70 kB 12.54 kB
± No change No change

Generated by 🚫 dangerJS against 38fac2b

Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will personally save me a fair amount of time waiting for app uploads to BrowserStack with my slow internet.

@fractalwrench fractalwrench merged commit 87c3946 into next Dec 17, 2020
@fractalwrench fractalwrench deleted the PLAT-5621/rn-apk-size branch December 17, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants