Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bugsnag integrity header to Expo #1172

Merged
merged 6 commits into from
Dec 4, 2020
Merged

Add Bugsnag integrity header to Expo #1172

merged 6 commits into from
Dec 4, 2020

Conversation

imjoehaines
Copy link
Contributor

@imjoehaines imjoehaines commented Dec 3, 2020 •
edited
Loading

Goal

Adds the Bugsnag-Integrity header to Expo delivery, using expo-crypto to calculate the sha1 hash of the payload

Testing

Covered by automated tests & tested manually on a fresh Expo project

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Dec 3, 2020 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.70 kB 12.54 kB
After 40.70 kB 12.54 kB
± No change No change

Generated by 🚫 dangerJS against f91879f

@imjoehaines imjoehaines marked this pull request as ready for review December 4, 2020 09:44
bengourley
bengourley approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out locally. Events and sessions successfully sent to the dashboard. Pointed the notifier at a local endpoint too, inspected the payloads and confirmed they contain the integrity header.

@imjoehaines imjoehaines merged commit e9d730c into next Dec 4, 2020
@imjoehaines imjoehaines deleted the integration/bugsnag-integrity-header branch December 10, 2020 10:50
@djskinner djskinner mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengourley bengourley bengourley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imjoehaines @bugsnagbot @bengourley @twometresteve