Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repetitive logging from React Native test fixtures #1111

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

twometresteve
Copy link
Contributor

Goal

Removes repetitive logging that only makes it harder to find the relevant part of a device log when a test scenario fails.

Design

This appears to be a hangover from the original test development phase and doesn't seem to serve a positive purpose anymore.

Changeset

Logging removed from React Native test fixtures.

Testing

Covered by standard CI.

@bugsnagbot
Copy link
Collaborator

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.57 kB 12.52 kB
After 40.57 kB 12.52 kB
± No change No change

Generated by 🚫 dangerJS against 48d4dd7

@twometresteve twometresteve merged commit 581e3a0 into next Oct 23, 2020
@twometresteve twometresteve deleted the tms/hindering-logging branch October 23, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants