Ensure every buildkite step has a timeout #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengourley
approved these changes
Oct 22, 2020
Yes, absolutely - the majority were due to the MazeRunner image disappearing, which has now been dealt with. The Android 9 tests do certainly seem to need some attention separately in due course though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds timeouts to Buildkite steps that were missing them.
Design
Every step should have a timeout, even if far in excess of what might be needed. Whilst the infrastructure will scale, the number of instances are capped - potentially adding to CI congestion and there is a cost implication too.
Changeset
React Native pipeline - Expo and the main JS ones were ok.
Testing
Covered by standard CI.