Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ESLint violations in React Native test fixtures #1099

Merged
merged 5 commits into from
Oct 15, 2020

Conversation

twometresteve
Copy link
Contributor

Goal

Resolves several ESLint violations in the React Native test fixtures.

Design

Apologies for the slightly unwieldy PR - it was very easy to produce with the help of an ESLint literate IDE!

Changeset

The most important aspects of the PR are:

  • The updated ignore file, which brings the React Native test folder into scope (but not other test folders at this stage). This ensures that npm run test:lint catches violations when run locally.
  • Addition of test to Dockerfile.ci, ensuring that the files are in scope for Linting in CI.

Testing

In addition to passing CI:

  • Verified that npm run test:lint gives a clean result locally (and detects the deliberate introduction of a violation in the RN test fixtures).
  • Verified that errors will be caught on CI (this was initially missed when working the branch and hence the change to Dockerfile.ci.

@bugsnagbot
Copy link
Collaborator

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.57 kB 12.52 kB
After 40.57 kB 12.52 kB
± No change No change

Generated by 🚫 dangerJS against b7fa1a1

Base automatically changed from react-native-fixture to next October 14, 2020 08:40
Copy link
Contributor

@djskinner djskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@twometresteve twometresteve merged commit c5a68da into next Oct 15, 2020
@twometresteve twometresteve deleted the rn-test-fixture-linting branch October 15, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants