Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(plugin-expo-device): convert tests #1078

Merged
merged 1 commit into from
Oct 12, 2020
Merged

test(plugin-expo-device): convert tests #1078

merged 1 commit into from
Oct 12, 2020

Conversation

djskinner
Copy link
Contributor

Goal

Conversion of tests from jasmine to jest and TypeScript for consistency and performance and improved type checking.

Design

See previous discussions

Changeset

Converted plugin-expo-device tests from jasmine to jest.

Testing

Automated tests pass. Changes to test files, internal types and configuration only.

@bugsnagbot
Copy link
Collaborator

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.62 kB 12.23 kB
After 39.62 kB 12.23 kB
± No change No change

Generated by 🚫 dangerJS against 41e6eef

Base automatically changed from convert-tests-to-jest-2 to next October 12, 2020 10:39
@djskinner djskinner marked this pull request as ready for review October 12, 2020 10:42
@djskinner djskinner merged commit f3398f6 into next Oct 12, 2020
@djskinner djskinner deleted the convert-tests-to-jest-3 branch October 12, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengourley bengourley bengourley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djskinner @bugsnagbot @bengourley