[PLAT-5010]: Create React Navigation plugin #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengourley
force-pushed
the
bengourley/react-navigation-plugin
branch
from
a65f161
to
dd57e42
Compare
imjoehaines
reviewed
Sep 24, 2020
packages/plugin-react-navigation/types/bugsnag-plugin-react-navigation.d.ts
Outdated
Show resolved
Hide resolved
imjoehaines
reviewed
Sep 24, 2020
packages/plugin-react-navigation/test/react-navigation.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
imjoehaines
approved these changes
Sep 25, 2020
Merged
|
Just curious, what happens with this change if we were already leaving breadcrumbs and setting context? Are we going to end up with duplicate logs? Should be listed as a breaking change if so. |
This plugin has to be installed manually (it doesn't get pulled in automatically by If you'd like to migrate to using the plugin instead of your custom solution, the docs are here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a plugin that integrates with React Navigation.
The new plugin hooks in to
onStateChangeevents to perform the following actions:contextso that when an error happens, so the developer can immediately see which screen it happened onNote, end to end tests to follow in separate PRs as it requires a significant amount of @bugsnag/platforms-test-automation input.