Add plugin for React Native Navigation

[imjoehaines]

Goal

This PR adds a plugin for React Native Navigation. This plugin sets the context to the name of the currently rendered component and leaves a breadcrumb on each navigation change

Usage:

import { Navigation } from 'react-native-navigation'
import Bugsnag from '@bugsnag/react-native'
import BugsnagPluginReactNativeNavigation from '@bugsnag/plugin-react-native-navigation'

Bugsnag.start({
  plugins: [new BugsnagPluginReactNativeNavigation(Navigation)]
})

[bugsnagbot]

@bugsnag/browser bundle size diff

	Minified	Minfied + Gzipped
Before	40.57 kB	12.52 kB
After	40.57 kB	12.52 kB
±	No change	No change

Generated by 🚫 dangerJS against 1a885ba

[bengourley]

Looks good. Nice and simple.

• Have you tested it manually on an example app?
• As a top-level plugin it will need types (there will be a similar example when I push my branch in a bit)
• A docs PR is needed

[imjoehaines]

Have you tested it manually on an example app?

Yeah, I've tested v2, v3, v4, v5, v6 & v7

As a top-level plugin it will need types (there will be a similar example when I push my branch in a bit)

Added in 5d64d90

A docs PR is needed

👍

[bengourley]

Looks good, manually verified working as expected on an example project.

[twometresteve]

No comments from a test perspective.

[Cawllec]

I tripped up creating the test fixtures because I'd not passed Navigation into the new BugsnagReactNativeNavigation() call.

It took a while to debug due to not having an error message, just a silent failure. Can we add some sort of message to that?

[imjoehaines]

I tripped up creating the test fixtures because I'd not passed Navigation into the new BugsnagReactNativeNavigation() call.

It took a while to debug due to not having an error message, just a silent failure. Can we add some sort of message to that?

We could but it definitely shouldn't be a silent failure; as soon as load is called it will try to call a method on Navigation. If it's not passed in that will throw, with a stacktrace pointing to the plugin. Were javascript errors being suppressed somehow in the way the tests are setup?

I think it's fine to add an error anyway though — what do you think @bengourley?

[bengourley]

It's not silent, but I guess crucially the error happens after the mistake was made. I think it would be a reasonable improvement to add a more friendly error in the constructor.

Though this got me thinking, is there a use case for passing in Navigation later, in the way that we do with the React and Vue plugins?