Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(plugin-network-breadcrumbs): convert tests #1057

Merged
merged 1 commit into from
Sep 28, 2020
Merged

test(plugin-network-breadcrumbs): convert tests #1057

merged 1 commit into from
Sep 28, 2020

Conversation

djskinner
Copy link
Contributor

Goal

Conversion of tests from jasmine to jest and TypeScript for consistency and performance and improved type checking.

Design

See previous discussions

Changeset

Converted plugin-network-breadcrumbs tests from jasmine to jest.

Testing

Automated tests pass. Changes to test files, internal types and configuration only.

@djskinner djskinner requested a review from a team as a code owner September 21, 2020 13:55
@bugsnagbot
Copy link
Collaborator

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.62 kB 12.23 kB
After 39.62 kB 12.23 kB
± No change No change

Generated by 🚫 dangerJS against 6cb59fc

twometresteve
twometresteve reviewed Sep 22, 2020
View reviewed changes
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this from a test perspective.

@bengourley bengourley merged commit 1b470e5 into next Sep 28, 2020
@bengourley bengourley deleted the convert-tests-to-jest branch September 28, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twometresteve twometresteve twometresteve left review comments

@bengourley bengourley bengourley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djskinner @bugsnagbot @bengourley @twometresteve