fix(lerna): replace non-semver characters publishing #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Avoid characters such a
_in Git branch name breaking the build.Design
This is a slight improvement on the current situation, but still not infallible overall. For example, there are characters that can be used in branch names that are incompatible with Docker tag names - as used in the pipeline. I have raised an internal ticket to conduct a review of such uses in a view to developing a foolproof scheme.
Changeset
JS script responsible for determining the package version to use for the current CI run.
Testing
In addition to the standard CI, I intentionally named this branch in a way that could break the build or lead to erroneous results (in particular
_,/and upper case letters).