Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(plugin-client-ip): convert tests #1017

Merged
merged 2 commits into from
Aug 28, 2020
Merged

test(plugin-client-ip): convert tests #1017

merged 2 commits into from
Aug 28, 2020

Conversation

djskinner
Copy link
Contributor

Goal

  • Conversion of tests from jasmine to jest and TypeScript for consistency and performance and improved type checking.

Design

See previous discussions

Changeset

Converted plugin-client-ip tests from jasmine to jest.

Testing

Automated tests pass. Changes to test files, internal types and configuration only.

@djskinner djskinner requested a review from a team as a code owner August 25, 2020 15:03
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Aug 25, 2020 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.62 kB 12.23 kB
After 39.62 kB 12.23 kB
± No change No change

Generated by 🚫 dangerJS against 48d6139

@djskinner djskinner merged commit cdfaa27 into next Aug 28, 2020
@djskinner djskinner deleted the convert-tests-to-jest-3 branch August 28, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengourley bengourley bengourley approved these changes

@twometresteve twometresteve twometresteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djskinner @bugsnagbot @bengourley @twometresteve