fix(config): Iterate over values provided instead of those allowed

bugsnag · Nov 19, 2019 · fa55906 · fa55906
1 parent 49a4658
commit fa55906
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/core/config.js b/packages/core/config.js
@@ -73,7 +73,7 @@ module.exports.schema = {
   enabledBreadcrumbTypes: {
     defaultValue: () => BREADCRUMB_TYPES,
     message: `should be null or a list of available breadcrumb types (${BREADCRUMB_TYPES.join(',')})`,
-    validate: value => value === null || (isArray(value) && reduce(BREADCRUMB_TYPES, (accum, maybeType) => {
+    validate: value => value === null || (isArray(value) && reduce(value, (accum, maybeType) => {
       if (accum === false) return accum
       return includes(BREADCRUMB_TYPES, maybeType)
     }, true))

diff --git a/packages/core/test/config.test.js b/packages/core/test/config.test.js
@@ -64,4 +64,11 @@ describe('@bugsnag/core/config', () => {
       })
     })
   })
+
+  describe('enabledBreadcrumbTypes', () => {
+    it('fails when a supplied value is not a valid breadcrumb type', () => {
+      const enabledBreadcrumbTypesValidator = config.schema.enabledBreadcrumbTypes.validate
+      expect(enabledBreadcrumbTypesValidator(['UNKNOWN_BREADCRUMB_TYPE'])).toBe(false)
+    })
+  })
 })