feat(plugin-browser-device) add orientation fallback

bugsnag · Jun 17, 2020 · 64fd89e · 64fd89e
1 parent 9c778bf
commit 64fd89e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/packages/plugin-browser-device/device.js b/packages/plugin-browser-device/device.js
@@ -3,15 +3,20 @@ const assign = require('@bugsnag/core/lib/es-utils/assign')
 /*
  * Automatically detects browser device details
  */
-module.exports = (nav = navigator, _screen = window.screen) => ({
+module.exports = (nav = navigator, screen = window.screen) => ({
   load: (client) => {
     const device = {
       locale: nav.browserLanguage || nav.systemLanguage || nav.userLanguage || nav.language,
       userAgent: nav.userAgent
     }
 
-    if (_screen && _screen.orientation && _screen.orientation.type) {
-      device.orientation = _screen.orientation.type
+    if (screen && screen.orientation && screen.orientation.type) {
+      device.orientation = screen.orientation.type
+    } else {
+      device.orientation =
+        document.documentElement.clientWidth > document.documentElement.clientHeight
+          ? 'landscape'
+          : 'portrait'
     }
 
     client.addOnSession(session => {

diff --git a/packages/plugin-browser-device/test/device.test.ts b/packages/plugin-browser-device/test/device.test.ts
@@ -20,7 +20,7 @@ describe('plugin: device', () => {
     expect(payloads[0].events[0].device.time instanceof Date).toBe(true)
     expect(payloads[0].events[0].device.locale).toBe(navigator.language)
     expect(payloads[0].events[0].device.userAgent).toBe(navigator.userAgent)
-    expect(payloads[0].events[0].device.orientation).toBe(undefined)
+    expect(payloads[0].events[0].device.orientation).toBe('portrait')
   })
 
   it('should capture the screen orientation if possible and add it to the event', () => {
@@ -58,7 +58,7 @@ describe('plugin: device', () => {
     expect(payloads[0].device).toBeDefined()
     expect(payloads[0].device && payloads[0].device.locale).toBe(navigator.language)
     expect(payloads[0].device && payloads[0].device.userAgent).toBe(navigator.userAgent)
-    expect(payloads[0].device && payloads[0].device.orientation).toBe(undefined)
+    expect(payloads[0].device && payloads[0].device.orientation).toBe('portrait')
   })
 
   it('should capture the screen orientation if possible and add it to the session', () => {