Navigator.pushAndRemoveUntil throws exception in Bugsnag #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-smartbear
changed the title
lemnik
reviewed
Apr 23, 2024
| @@ -291,7 +291,7 @@ Void clearFeatureFlags(@Nullable JSONObject args) { | |||
| } | |||
|
|
|||
| Void addMetadata(@Nullable JSONObject args) throws JSONException { | |||
| if (args == null || !args.has("section") || !args.has("metadata")) { | |||
| if (args == null || !hasString(args,"section") || args.has("metadata")) { | |||
There was a problem hiding this comment.
nit: formatting
Suggested change
| if (args == null || !hasString(args,"section") || args.has("metadata")) { | |
| if (args == null || !hasString(args, "section") || args.has("metadata")) { |
packages/bugsnag_flutter/android/src/main/java/com/bugsnag/flutter/BugsnagFlutter.java
Outdated
Show resolved
Hide resolved
packages/bugsnag_flutter/android/src/main/java/com/bugsnag/flutter/BugsnagFlutter.java
Outdated
Show resolved
Hide resolved
| @@ -317,7 +317,7 @@ Void clearMetadata(@Nullable JSONObject args) throws JSONException { | |||
| } | |||
|
|
|||
| JSONObject getMetadata(@Nullable JSONObject args) throws JSONException { | |||
| if (args == null || !args.has("section")) { | |||
| if (args == null || !hasString(args,"section")) { | |||
There was a problem hiding this comment.
nit: formatting
Suggested change
| if (args == null || !hasString(args,"section")) { | |
| if (args == null || !hasString(args,"section")) { |
Comment on lines
408
to
410
| if (!args.has(key)) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
I think this check is redundant, if args.get(key) returns null the instanceof String check will fail and we return null.
Co-authored-by: Jason <lemnik@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixed an issue related to setting context by navigator observer. In some cases a null is received on Android as a JSONObject.
Changeset
Added safety checks
Testing
Manual testing