Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-8044] Network breadcrumbs for dart:io HttpClient #116

Merged
merged 10 commits into from
Jun 9, 2022

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented May 24, 2022

Goal

Capture network breadcrumbs when using dart:io

Design

Implements a wrapper around the HttpClient class.

Changeset

Adds a bugsnag_breadcrumbs_dart_io package that implements BugsnagHttpClient, which apps should as a replacement for dart:io's HttpClient.

Renames bugsnag_flutter_http to bugsnag_breadcrumbs_http .

Testing

@nickdowell nickdowell changed the title Network breadcrumbs for dart:io HttpClient [PLAT-8044] Network breadcrumbs for dart:io HttpClient May 24, 2022
Base automatically changed from nickdowell/network-breadcrumbs-http to next June 7, 2022 08:42
@nickdowell nickdowell force-pushed the nickdowell/network-breadcrumbs-httpclient branch from 9b8bd8d to 19e652d Compare June 7, 2022 12:25
@nickdowell nickdowell force-pushed the nickdowell/network-breadcrumbs-httpclient branch from 720decc to fa73d25 Compare June 8, 2022 12:32
@nickdowell nickdowell marked this pull request as ready for review June 8, 2022 12:37
@nickdowell nickdowell requested a review from lemnik June 8, 2022 12:37
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM With some minor formatting suggestions

@nickdowell nickdowell requested a review from lemnik June 8, 2022 13:39
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemnik
Copy link
Contributor

lemnik commented Jun 9, 2022

Changelog entry?

@nickdowell nickdowell merged commit 7e1ca16 into next Jun 9, 2022
@nickdowell nickdowell deleted the nickdowell/network-breadcrumbs-httpclient branch June 9, 2022 13:22
@lemnik lemnik mentioned this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants