Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crashes on Web #185

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

yousif-bugsnag
Copy link
Contributor

Goal

Prevent apps from crashing on web platform:

Design

Although Web isn't officially supported, this should at least prevent the app from crashing. However this means that device ids will no longer be reported on web, so user stability scores will not work.

Testing

  • Relied on existing unit and CI tests to ensure that device IDs are still generated and persisted on Android and iOS
  • Manually tested on web

@giaset
Copy link

giaset commented Jun 4, 2024

If you want to support (at least some form of) device ID on web, I ended up doing this: #183 (comment)

@yousif-bugsnag yousif-bugsnag marked this pull request as ready for review June 11, 2024 14:47
@yousif-bugsnag
Copy link
Contributor Author

Hi @giaset, thanks for sharing that patch.

Seems sensible enough, however we don't currently support Expo on web, and it's not a platform we test against - so although this PR should prevent the reported crash, we won't be adding web-specific functionality to the library at this time.

@yousif-bugsnag yousif-bugsnag merged commit 5cf7d85 into v51/next Jun 11, 2024
6 checks passed
@yousif-bugsnag yousif-bugsnag deleted the PLAT-12164/secure-store-web-crash branch June 11, 2024 15:30
@yousif-bugsnag yousif-bugsnag mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants