Remove BSGDictSetSafeObject and BSGArrayAddSafeObject #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
reviewed
Dec 7, 2020
nickdowell
force-pushed
the
nickdowell/remove-safe-object-functions
branch
from
93cafce
to
d4cc31b
Compare
nickdowell
force-pushed
the
nickdowell/remove-safe-object-functions
branch
from
8764f25
to
2d21405
Compare
nickdowell
force-pushed
the
nickdowell/remove-safe-object-functions
branch
from
2d21405
to
34d2ef0
Compare
kstenerud
approved these changes
Dec 8, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
BSGDictSetSafeObjectdoes not make our code safer - in fact it makes it more error prone because it means we can end up with[NSNull null]values in dictionaries, which then need to be guarded against when reading back from the dictionary (this is something our code does not currently do.)Changeset
BSGDictSetSafeObjectandBSGArrayAddSafeObjecthave been removed.Testing
Tested by running unit tests.