[PLAT-5450] Add missing app and device data to OOM events #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
changed the title
kstenerud
reviewed
Nov 25, 2020
kstenerud
approved these changes
Nov 25, 2020
Capturing the battery and orientation values in the initial creation of the BugsnagSystemState object ensures they will be there when the app is terminated to simulate an OOM. The test was sometimes failing because BugsnagSystemState queues up asynchronous writes in the background and these do not always have time to complete when running the test scenario.
nickdowell
force-pushed
the
nickdowell/app-and-device-data-for-ooms
branch
from
175a443
to
007e2fa
Compare
kattrali
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Out Of Memory errors have been missing some of the information present in other types of errors reported by Bugsnag.
The aim of this PR is to add the following data:
batteryLevelchargingdsymUUIDsmanufacturerorientationruntimeVersionstotalMemoryDesign
The additional information is captured in
BugnagSystemStateas this information is already being used to generate the OOM error payload.Changeset
BugnagSystemStatehas been amended to capture additional information.BugsnagAppWithState,BugsnagDeviceWithStateandBugsnagEventhave been updated to read this new information.Testing
Manually tested and verified by examining the payloads sent to the notify endpoint.