Add user-available post-crash handler #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a separate feature/pr if required. We could add a pre-send handler. In there you could safely run objective-c code, but it wouldnt be in the crashing context. This would be good for adding user information or editing the stacktrace/grouping hash etc. |
| @@ -72,6 +74,9 @@ void BSSerializeDataCrashHandler(const KSCrashReportWriter *writer) { | |||
| if (g_bugsnag_data.stateJSON) { | |||
| writer->addJSONElement(writer, "state", g_bugsnag_data.stateJSON); | |||
| } | |||
| if (g_bugsnag_data.onCrash) { | |||
| g_bugsnag_data.onCrash(); | |||
There was a problem hiding this comment.
Can we sensibly pass it anything? The writer? Could we do something sensible with the return value?
Usually we pass the payload in and you can edit it. And then the return value is a bool true/false to send it or not.
kattrali
force-pushed
the
kattrali/add-user-on-crash-handler
branch
from
8747bba
to
4368381
Compare
|
That's a good point. I was wondering how to integrate #17 with this, and I bet that would be cleanest. |
kattrali
added a commit
that referenced
this pull request
Feb 5, 2016
Make post-crash handler available to users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34.