Refactored OOM handler to use the new key-value store #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored BSGOutOfMemoryWatchdog to use the new kwy-value store. Removed unneeded public interfaces to BSGOutOfMemoryWatchdog, and renamed some properties and methods to better reflect the purpose of the class. Added OOM logic tests.
kstenerud
force-pushed
the
5004-oom-kv-store
branch
from
250edc2
to
fb2ca6c
Compare
kstenerud
force-pushed
the
5004-oom-kv-store
branch
from
fb2ca6c
to
435455e
Compare
kattrali
approved these changes
Sep 16, 2020
This was referenced Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new low-level key-value store gives faster and more direct access for storing information critical to detecting OOM errors. This PR refactors
BSGOutOfMemoryWatchdogto use the new K-V store, and also provides a nicer Objective-C interface to the store.The K-V store is now the source of all truth for information used to detect OOM. Information incidentally written out to the sentinel file is secondary.
Note: The class is still a bit messy because it has more than one responsibility. Separating out concerns will be the subject of a later PR.
Fixes https://bugsnag.atlassian.net/browse/PLAT-5004