Persist user when set on client #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
fix-persist-user
branch
from
3130f0d
to
3f5d7b7
Compare
fractalwrench
force-pushed
the
fix-persist-user
branch
from
3f5d7b7
to
e97716b
Compare
fractalwrench
force-pushed
the
fix-persist-user
branch
from
e97716b
to
180d94b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Ensures that when
config.persistUseristrueand the user is set on theClient, that the user information is persisted for the next launch. This changeset ensures that theClientproperty sets theConfigurationuser property, which stores the information inNSUserDefaults. Additionally an E2E scenario has been added to test setting the user onClient.