Add onCrashHandler data to BugsnagEvent metadata #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
v6-oncrash-data
branch
from
cb2dd94
to
679633b
Compare
tomlongridge
approved these changes
Apr 23, 2020
Source/KSCrash/Source/KSCrash/Recording/BSG_KSCrashReportFields.h
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Data which is added in the onCrashHandler is now added to error reports in an
onCrashmetadata tab. This provides a replacement for the previous API which allowed for these values to be inspected (but not reported) in the now removedrawDataparameter.Changeset
userinformation when constructing aBugsnagEventfrom a KSCrash reportuserobject that are not user-added dataonCrashmetadata tabTests
Added a unit test to verify behaviour of
onCrashdata parsing. Manually testedonCrashHandlerfunctionality in an example app and verified the value was sent to the dashboard.