Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make bundleVersion configurable in config. #550

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Conversation

robinmacharg
Copy link
Contributor

Goal

The bundleVersion property should be a configurable property on BugsnagConfiguration to provide equivalence with the Android notifier versionCode.

Design

Followed the pattern set by other similar configurable properties, e.g. appVersion.

Changeset

Added a property to BungsnagConfiguration, updated BugsnagApp to allow user-overriding of this value on events.

Tests

Single test following appVersion example.

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
    • Release
  • The correct target branch has been selected (master for fixes, next for
    features)
  • If this is intended for release have all of the pre-release checks been considered?
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg marked this pull request as ready for review April 20, 2020 15:59
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robinmacharg robinmacharg merged commit 0a2efd9 into v6 Apr 21, 2020
@robinmacharg robinmacharg deleted the v6-bundleVersion branch April 21, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants