Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sendThreads property to BugsnagConfiguration #549

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds the sendThreads to BugsnagConfiguration. This allows a user to record thread information always, for unhandled errors only, or never.

Note that the stacktrace of the crashing thread is always recorded and reported in the thread tab.

Changeset

  • Added publicly visible BSGThreadSendPolicy enum and sendThreads property
  • Passed value of sendThreads into KSCrash during its initialisation
  • Altered KSCrash to take an int rather than a bool for the threadTracingEnabled value
  • Added logic to only serialize all threads if the user has specified to do so

Tests

  • Added unit tests to verify default value and copying of thread information in BugsnagConfiguration
  • Manually verified behaviour in an example app

Copy link
Contributor

@robinmacharg robinmacharg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple of minor nits, approved on the basis that you'll use best judgement on these.

@fractalwrench fractalwrench merged commit 610ffc7 into v6 Apr 21, 2020
@fractalwrench fractalwrench deleted the v6-send-threads branch April 21, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants