Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add originalError property to BugsnagEvent #541

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds the originalError property to BugsnagEvent, as per the notifier spec.

This property contains the value of either the NSError or NSException which caused the error, if they are available. Otherwise the value will be nil.

Changeset

Populated the originalError property with the causing NSException or NSError.

Tests

Manually verified that the properties are populated when calling Bugsnag.notify.

Copy link
Contributor

@robinmacharg robinmacharg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good comment on the property.

@fractalwrench fractalwrench merged commit 7d50435 into v6 Apr 15, 2020
@fractalwrench fractalwrench deleted the v6-original-error branch April 15, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants