Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robin/rename bugsnag notifier class to bugsnag client #480

Conversation

robinmacharg
Copy link
Contributor

Goal

Rename the BugsnagNotifier class to BugsnagClient.

Design

XCode refactor of the principle class, search/refactor instances of notifier to client appropriately.

Changeset

Various files:

M	Source/Bugsnag.m
R098	Source/BugsnagNotifier.h	Source/BugsnagClient.h
R099	Source/BugsnagNotifier.m	Source/BugsnagClient.m
M	Source/BugsnagConfiguration.h
M	Source/BugsnagConfiguration.m
M	Source/BugsnagErrorReportApiClient.m
M	Source/BugsnagKSCrashSysInfoParser.m
M	Source/BugsnagSessionTrackingPayload.m
M	Source/BugsnagSink.m
M	Tests/BugsnagBaseUnitTest.m

Tests

Code compiles, Unit Tests all pass.

Review

Outstanding Questions

The library is still conceptually a 'Notifier'; The class has been renamed to better indicate its purpose (as a client communicating with the Bugsnag backend). Are the changes appropriate, have any instances of 'notifier' in the source not been renamed when they should have been?

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg force-pushed the robin/Rename-BugsnagNotifier-class-to-BugsnagClient branch from 6de0adb to 9f86656 Compare March 5, 2020 16:47
@robinmacharg robinmacharg marked this pull request as ready for review March 5, 2020 16:49
Source/BugsnagClient.m Outdated Show resolved Hide resolved
Source/BugsnagConfiguration.h Outdated Show resolved Hide resolved
Tests/BugsnagBaseUnitTest.m Outdated Show resolved Hide resolved
Source/BugsnagKSCrashSysInfoParser.m Outdated Show resolved Hide resolved
@robinmacharg robinmacharg merged commit 65089f3 into spec-compliance Mar 10, 2020
@fractalwrench fractalwrench deleted the robin/Rename-BugsnagNotifier-class-to-BugsnagClient branch May 13, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants