Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added a mutable Bugsnag.context property #466

Merged

Conversation

robinmacharg
Copy link
Contributor

Goal

Add a mutable context property to Bugsnag.

Design

Simple passthrough to the equivalent BugsnagConfiguration property.

Changeset

The Bugsnag class.

Tests

Unit tests that top-level manipulation affected the Configuration value as expected.

Review

Outstanding Questions

Concurrency concerns are deferred to the underlying Configuration property.

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

Source/BugsnagEvent.m Outdated Show resolved Hide resolved
Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@robinmacharg robinmacharg marked this pull request as ready for review February 19, 2020 16:15
@kattrali kattrali force-pushed the Add-a-setter-for-context-on-the-Bugsnag-interface branch from 9ca90af to faa1627 Compare February 24, 2020 10:06
@kattrali kattrali merged commit 5084f37 into spec-compliance Feb 24, 2020
@kattrali kattrali deleted the Add-a-setter-for-context-on-the-Bugsnag-interface branch February 24, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants