Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Rename Bugsnag.stopSession to Bugsnag.pauseSession #464

Conversation

robinmacharg
Copy link
Contributor

Goal

Rename Bugsnag.stopSession to Bugsnag.pauseSession

Design

Simple rename. Search and replace.

Changeset

Just occurrences in Bugsnag and a single test.

Tests

There was no testing for this feature. Without refactoring to use dependency injection or mocking it's difficult to test the session pausing feature. For now there's a simple placeholder test that proves that the method exists.

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg force-pushed the robinmacharg/Rename-Bugsnag.stopSession-to-Bugsnag.pauseSession branch from 653def8 to 7af7842 Compare February 13, 2020 11:45
@robinmacharg robinmacharg marked this pull request as ready for review February 13, 2020 11:46
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few callsites which still use stopSession that need updating.

  • Bugsnag
  • BugsnagNotifier
  • BugsnagSessionTracker

Additionally several of the mazerunner scenarios use the old stopSession syntax, or need renaming as a class (e.g. StoppedSessionScenario.swift)

Fixing missed occurrences of stopSession.
The functionality was actually added in commit f4b69a9.  This commit tidies it up slightly.

Added PR
@robinmacharg robinmacharg merged commit 53a1219 into spec-compliance Feb 18, 2020
@robinmacharg robinmacharg deleted the robinmacharg/Rename-Bugsnag.stopSession-to-Bugsnag.pauseSession branch February 18, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants