Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to build when using Carthage #423

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Fix failure to build when using Carthage #423

merged 5 commits into from
Oct 16, 2019

Commits on Oct 16, 2019

  1. build: Include platform-specific framework linking in xcconfig file 

    Fixes an issue where cocoa.framework is being requested from iOS builds
    @kattrali
    kattrali committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    cd89d5a View commit details
    Browse the repository at this point in the history

  2. build: Fix macOS use with Carthage by working around wrong build paths 

    FB7365403
    @kattrali
    kattrali committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    32a6421 View commit details
    Browse the repository at this point in the history

  3. build: Remove now unneeded workspaces 

    Also reduces confusion where Carthage may pick "OSX.xcworkspace" to
build for an iOS project
    @kattrali
    kattrali committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    9b40bd9 View commit details
    Browse the repository at this point in the history

  4. ci: Test against Carthage build

    @kattrali
    kattrali committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    c15d64e View commit details
    Browse the repository at this point in the history

  5. build: Fix linking issue in tvOS test target

    @kattrali
    kattrali committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    d842248 View commit details
    Browse the repository at this point in the history