Fix inForeground value for reports which launch and crash without coming to the foreground #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an app launches due to a background event but then crashes without ever coming to the foreground, the
inForegroundvalue is presumed to betrue, a default which made sense back before background launches were possible or common. This change refactors the foreground state logic in the OutOfMemoryWatchdog to be available to the initialization process, capturing the correct initial value.Tests
I couldn't find a way to force a background launch via an event anymore in the simulator (though there is a "Simulate Background Fetch" debug option that doesn't seem to launch an app if it isn't already running). So manual testing covered it by using media controls to launch a player app which then crashed and showed the correct foreground state