Migrate version information to device.runtimeVersions #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cawllec
reviewed
Apr 24, 2019
kattrali
approved these changes
Apr 24, 2019
kattrali
pushed a commit
that referenced
this pull request
May 1, 2019
kattrali
pushed a commit
that referenced
this pull request
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We should collect the OS build field in
device.runtimeVersions.apiLevelfor all error reports and sessions.Changeset
Moved
device.osBuildtodevice.runtimeVersions.osBuildTests
Ran existing tests and created new mazerunner scenarios, which verify that an error and session payload both include
device.runtimeVersions.osBuild.