fix: Use exception stack when available #334
Conversation
For thrown exceptions, use the exception stack trace rather than a generated one to allow notify() to be called from a different thread or handler.
kattrali
force-pushed
the
kattrali/macos-test-fix
branch
from
6aaeed5
to
2fb60c2
Compare
| @@ -181,7 +181,8 @@ __deprecated_msg("Use toJson: instead."); | |||
| */ | |||
| @property(readonly, copy, nonnull) NSDictionary *overrides; | |||
| /** | |||
| * Number of frames to discard at the top of the stacktrace | |||
| * Number of frames to discard at the top of the generated stacktrace. | |||
| * Stacktraces from raised exceptions are unaffected. | |||
There was a problem hiding this comment.
We should also update our docs so they state this.
| NSArray *addresses = [exception callStackReturnAddresses]; | ||
| NSUInteger numFrames = [addresses count]; | ||
| uintptr_t *callstack = malloc(numFrames * sizeof(*callstack)); | ||
| for (NSUInteger i = 0; i < numFrames; i++) { |
There was a problem hiding this comment.
How does this perform with very large stacktraces e.g. recursion gone wrong? The previous implementation has a limit of 100 frames.
There was a problem hiding this comment.
Unlimited stack errors can’t be caught and notified. This implementation is more in line with uncaught NSException handling.
| block(report); | ||
| } | ||
| }]; | ||
| [self notify:exception handledState:state block:block]; |
There was a problem hiding this comment.
Would this alter the depth of the stack, as there's no longer an extra block?
There was a problem hiding this comment.
Yes, technically, however for how we use it, no. This function is only used in cocoa apps in react native, where a custom stacktrace is attached, disregarding depth altogether. And as it isn't a public interface, there should be no other effects.
Goal
Improve the debugging experience for caught
NSExceptions by providing the exception stack rather than a stack generated at the timenotify()is called.Design
If there is a stacktrace attached to an exception, uses the exception stack rather than generating a new one by passing
-[NSException callStackReturnAddresses]as auintptr_tarray toreportUserException. If the exception has not been thrown or the call stack addresses array is null, a stacktrace is generated as before.Changeset
depthargument to only affect generated stacktracesTests
Review
Outstanding Questions