Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce requiring API key to initialise notifier #280

Merged
merged 9 commits into from
May 24, 2018
Merged

Enforce requiring API key to initialise notifier #280

merged 9 commits into from
May 24, 2018

Commits on May 18, 2018

  1. test: Enforce non-nil api key 

    Alter the API key annotation to Nonnull rather than Nullable. If the API key is set as nil, the
value is ignored and a warning logged.
    @fractalwrench
    fractalwrench committed May 18, 2018
    Configuration menu
    Copy the full SHA
    084e88c View commit details
    Browse the repository at this point in the history

  2. feat: Gate Bugsnag calls with check to see if notifier initialised 

    Gates all methods in Bugsnag.m so that they no-op and log a warning if the notifier has not been
initialised. Also avoids initialising the notifier if the API key is not supplied.
    @fractalwrench
    fractalwrench committed May 18, 2018
    Configuration menu
    Copy the full SHA
    1200634 View commit details
    Browse the repository at this point in the history

  3. docs: Add changelog entry for requiring api key

    @fractalwrench
    fractalwrench committed May 18, 2018
    Configuration menu
    Copy the full SHA
    71032ed View commit details
    Browse the repository at this point in the history

Commits on May 21, 2018

  1. test: Verify that configuration has a valid api key

    @fractalwrench
    fractalwrench committed May 21, 2018
    Configuration menu
    Copy the full SHA
    ce966a6 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2018

  1. refactor: Tweak apiKey config in response to review feedback

    @fractalwrench
    fractalwrench committed May 22, 2018
    Configuration menu
    Copy the full SHA
    47a3426 View commit details
    Browse the repository at this point in the history

  2. fix: Add a boolean property to check when notifier initialised rather… 

    … than checking null
    @fractalwrench
    fractalwrench committed May 22, 2018
    Configuration menu
    Copy the full SHA
    2638a69 View commit details
    Browse the repository at this point in the history

  3. fix(make started property atomic):

    @fractalwrench
    fractalwrench committed May 22, 2018
    Configuration menu
    Copy the full SHA
    1f6c4f3 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2018

  1. Keep key-value observability support 

    Since we already had it through synthesized properties, keeps it in
case its used.
    @kattrali
    kattrali committed May 24, 2018
    Configuration menu
    Copy the full SHA
    8a91bf8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into api-key-init-fixes

    @fractalwrench
    fractalwrench committed May 24, 2018
    Configuration menu
    Copy the full SHA
    3102f15 View commit details
    Browse the repository at this point in the history