Avoid generating and parsing invalid JSON files #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there was a parsing error, the buffer has random stuff in it and shouldn't be flushed to disk Introduced in 9b0d3fb
If a string starting with an integer (but not solely an integer) is passed as an argument to be decoded by the JSON parser, the parser will crash because NULL is eventually handed to strcmp(3). Integers aren't valid at the top level anyway.
|
Thanks so much @kattrali ! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that the crash state file fails to be written completely, avoid flushing the buffer as the file contents will be inconsistent. In addition, when parsing the file, add validation to avoid comparing a string to NULL.
To reproduce:
AppData/Library/Caches/KSCrashReport/{app name}-CrashState.jsonto3 }. This triggers the code path where the file is invalid but it is not rejected before crashing.Fixes #218