Parse notable addresses for Swift Assertion failure messages #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
reviewed
Oct 12, 2017
Source/BugsnagCrashSentry.m
Outdated
| @@ -24,7 +24,7 @@ - (void)install:(BugsnagConfiguration *)config | |||
| BugsnagSink *sink = [[BugsnagSink alloc] initWithApiClient:apiClient]; | |||
| [BSG_KSCrash sharedInstance].sink = sink; | |||
| // We don't use this feature yet, so we turn it off | |||
There was a problem hiding this comment.
Should change/remove the comment here
| addresses[@"r24"] = @{ | ||
| @"address": @4511084983, | ||
| @"type": @"string", | ||
| @"value": @"/usr/include/lib/something.swift" |
There was a problem hiding this comment.
Is there any value in including these addresses in other metadata?
There was a problem hiding this comment.
Quite possibly - I'll look into what sort of values are available for our Swift/Obj-C examples.
kattrali
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables memory introspection in KSCrash, which allows us to parse the notable addresses for Swift Assertion failure messages, as requested in #159. The message should now be captured for
fatalError,preconditionFailure,assertionFailure, andassert.This approach relies on heuristics - we'll inspect the variable values, and set the error message in the following conditions:
If this isn't the case, we won't alter the error message.