Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-12346] Remove inlined frame from the Bugsnag notify call chain entirely so t… #1667

Closed
wants to merge 1 commit into from

Conversation

kstenerud
Copy link
Contributor

Goal

Remove the call to functions that are getting inlined so that we don't have to worry about the size of the bugsnag portion of the stack (which will change if the call gets inlined).

Note: Do not merge this yet. We will also be trying a different approach.

…hat we don't accidentally strip too many frames from Bugsnag.notify
Copy link

Bugsnag.framework binary size decreased by 96 bytes from 718,312 to 718,216 🎉

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.7%    +112  +0.7%    +112    [__TEXT]
  [ = ]       0  +3.7%     +96    [__LINKEDIT]
  +0.6%     +32  +0.3%     +32    [__DATA]
  +0.1%      +4  +0.1%      +4    __TEXT,__unwind_info
  -0.0%     -16  -0.0%     -16    String Table
  -0.7%     -32  -0.7%     -32    __DATA,__objc_selrefs
  -0.1%     -80  -0.1%     -80    Symbol Table
  -0.0%    -116  -0.0%    -116    __TEXT,__text
  -0.0%     -96  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud
Copy link
Contributor Author

Superseded by #1668

@kstenerud kstenerud closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant