Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy info collisions #1630

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

robert-smartbear
Copy link
Contributor

Goal

Installing Bugsnag using Cocoapods was causing file collisions if the app had its own PrivacyInfo file

Design

Avoid the collisions by using resource_bundles instead of resources

Changeset

Replaces resources with resource_bundles in the podspec

Testing

Manual testing on an example app

Copy link

1 Error
🚫 Only release PRs should target the master branch

Bugsnag.framework binary size did not change - 713,208 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@tomlongridge tomlongridge changed the base branch from master to next February 16, 2024 17:01
@tomlongridge tomlongridge merged commit 24fc207 into next Feb 19, 2024
50 of 51 checks passed
@tomlongridge tomlongridge deleted the robert/plat_11590_privacy_info_collisions branch February 19, 2024 14:25
@kstenerud kstenerud mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants