Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watchOS CI builds/tests #1602

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

joshedney
Copy link
Contributor

Goal

Fix the flakey watchOS 7/8 tests on CI

Changeset

Change the default SDK for watchOS tests to watchsimulator

Dynamically get the name of the watchOS device due to an issue with naming after running xcodebuild -downloadAllPlatforms

Testing

Covered by CI

@joshedney joshedney self-assigned this Nov 3, 2023
@joshedney joshedney changed the base branch from master to next November 3, 2023 09:14
Copy link

github-actions bot commented Nov 3, 2023

Bugsnag.framework binary size decreased by 200 bytes from 713,304 to 713,104 🎉

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  +2.6%    +200    [__LINKEDIT]
  +0.2%     +32  +0.2%     +32    __DATA,__cfstring
  +0.2%     +30  +0.2%     +30    __TEXT,__cstring
  +0.0%      +2  +0.0%      +2    [__TEXT]
  -0.5%      -8  -0.5%      -8    Indirect Symbol Table
  -0.6%      -8  -0.6%      -8    __DATA,__la_symbol_ptr
  -0.0%      -8  -0.0%      -8    __TEXT,__text
  -0.6%     -12  -0.6%     -12    __TEXT,__stub_helper
  -0.6%     -12  -0.6%     -12    __TEXT,__stubs
  -0.6%     -24  -0.6%     -24    Lazy Binding Info
  -0.3%     -24  -0.2%     -24    [__DATA]
  -0.0%     -72  -0.0%     -72    String Table
  -0.1%     -96  -0.1%     -96    Symbol Table
  -0.0%    -200  [ = ]       0    TOTAL

Generated by 🚫 Danger

@twometresteve twometresteve merged commit 5b0409b into next Nov 3, 2023
37 checks passed
@twometresteve twometresteve deleted the je/fix-watchos-xcode-builds branch November 3, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants