Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plat-10822] Fix for duplicate C++ library warnings #1581

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

kstenerud
Copy link
Contributor

@kstenerud kstenerud commented Sep 11, 2023

Goal

Xcode 15 now warns about duplicate library flags during the linking phase.

Since c++ is now inferred by the compiler, adding -lc++ hasn't been necessary in Xcode for the past few versions.

This PR removes the manual -lc++ flags.

Testing

Reran all tests to ensure that this doesn't break any builds.

@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Bugsnag.framework binary size did not change - 713,488 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.3%     +48  +0.3%     +48    [__TEXT]
  -1.4%     -48  -1.4%     -48    [Mach-O Headers]
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud marked this pull request as ready for review November 15, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants