Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-9970] Include API key when serializing events to JSON #1547

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

yousif-bugsnag
Copy link
Contributor

Goal

Include the event's API key when serializing/deserilaising events to/from JSON.

Fixes an issue where an overridden API key is not preserved if the event is persisted to disk (for example if the event is marked as unhandled or if there is no network connection)

Changeset

Added API key to the initWithJson and toJsonWithRedactedKeys methods on BugsnagEvent

Testing

Updated the JSON serialization unit test for BugsnagEvent to include an API key

@github-actions
Copy link

Bugsnag.framework binary size did not change - 707,048 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +128  +0.1%    +128    __TEXT,__text
  -0.5%    -128  -0.5%    -128    [__TEXT]
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@yousif-bugsnag yousif-bugsnag merged commit 4df5d62 into next Apr 14, 2023
@yousif-bugsnag yousif-bugsnag deleted the yousif/PLAT-9970-persist-event-api-key branch April 14, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants