Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-9362] fix for data race and nullability issues #1515

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

kstenerud
Copy link
Contributor

Goal

PLAT-9362

Fixed a data race when getting the host memory reading.

There were also warnings about incorrect nullability invariant expectations in the code, which are also now fixed.

Testing

Tested manually, reran all unit and e2e tests.

@kstenerud kstenerud requested a review from lemnik January 10, 2023 09:04
@github-actions
Copy link

github-actions bot commented Jan 10, 2023

Bugsnag.framework binary size increased by 152 bytes from 706,296 to 706,448

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%     +80  +0.1%     +80    Symbol Table
  +0.0%     +64  +0.0%     +64    String Table
  +0.0%     +16  +0.0%     +16    __TEXT,__text
  +0.5%      +8  +0.5%      +8    Function Start Addresses
  +0.1%      +4  +0.1%      +4    __TEXT,__unwind_info
  -0.1%     -20  -0.1%     -20    [__TEXT]
  [ = ]       0  -1.0%    -152    [__LINKEDIT]
  +0.0%    +152  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the PLAT-9362-data-race branch 5 times, most recently from b1551a0 to ad1647e Compare January 10, 2023 10:37
Copy link

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kstenerud kstenerud merged commit 8f89a59 into next Jan 11, 2023
@kstenerud kstenerud deleted the PLAT-9362-data-race branch January 11, 2023 10:21
@kstenerud kstenerud mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants