[PLAT-8819] Add leaveNetworkRequestBreadcrumbForTask:metrics:
#1472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Facilitate leaving network request breadcrumbs without relying on the plugin's Objective-C method swizzling.
Design
+[Bugsnag leaveNetworkRequestBreadcrumbForTask:metrics:]
provides a public API for leaving a network request breadcrumb based on anNSURLSessionTask
andNSURLSessionTaskMetrics
.Changeset
Adds
+[Bugsnag leaveNetworkRequestBreadcrumbForTask:metrics:]
and-[BugsnagClient leaveNetworkRequestBreadcrumbForTask:metrics:]
.Moves breadcrumb message & metadata computation from
BSGURLSessionTracingDelegate
toBSGNetworkBreadcrumb.m
, called from-[BugsnagClient leaveNetworkRequestBreadcrumbForTask:metrics:]
.Calls
-[BugsnagClient leaveNetworkRequestBreadcrumbForTask:metrics:]
from-[BSGURLSessionTracingDelegate URLSession:task:didFinishCollectingMetrics:]
.Testing
Migrates and modifies existing unit tests to continue passing.
Verified by existing E2E scenario.