Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-8732] Send queued sessions when connection regained #1445

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Jul 21, 2022

Goal

Make session delivery behaviour similar to event delivery.

Changeset

Schedules scan & upload of stored sessions upon regaining network connection.

Exposes the BSGSessionUploader object in order to call this from existing connectivity listener.

Testing

Not covered by automated tests. Verified manually using example app.

@github-actions
Copy link

Bugsnag.framework binary size did not change - 804,664 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +80  +0.0%     +80    __TEXT,__text
  +0.2%      +2  +0.2%      +2    __TEXT,__objc_classname
  -0.3%     -82  -0.3%     -82    [__TEXT]
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@nickdowell nickdowell merged commit be2df10 into next Jul 25, 2022
@nickdowell nickdowell deleted the nickdowell/retry-sessions-upon-connectivity branch July 25, 2022 07:07
@nickdowell nickdowell mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants