Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plat-5196] Fix init order #1423

Merged
merged 1 commit into from
Jul 6, 2022
Merged

[Plat-5196] Fix init order #1423

merged 1 commit into from
Jul 6, 2022

Conversation

kstenerud
Copy link
Contributor

Goal

Some parts of the library were being used before initialization.

Design

Make sure the init functions are called before anything uses them. Also, don't allow arbitrary configs to be passed in to the lower levels when there's always a single global instance in reality.

Testing

Reran all tests.

@kstenerud kstenerud requested a review from nickdowell July 5, 2022 12:31
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Bugsnag.framework binary size did not change - 815,960 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +8  +0.0%      +8    [__TEXT]
  +0.2%      +8  +0.2%      +8    __TEXT,__unwind_info
  -0.0%     -16  -0.0%     -16    __TEXT,__text
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud merged commit 6f7061d into next Jul 6, 2022
@kstenerud kstenerud deleted the PLAT-5196-init-order branch July 6, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants