Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-8639] Add usage telemetry #1422

Merged
merged 6 commits into from
Jul 5, 2022
Merged

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Jul 5, 2022

Goal

Allow Bugsnag to determine usage of configuration options, to aid product development.

Changeset

Adds a "usage" telemetry configuration option.

Adds a function to create a usage dictionary based on current configuration - BSGTelemetryCreateUsage().

Includes "usage" in handled and crashing errors. OOMs and other kills intentionally out of scope.

Testing

BSGTelemetryCreateUsage() is covered by new unit tests.

E2E tests verify the presence of "usage" and that it is omitted when the telemetry option is disabled.

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Bugsnag.framework binary size increased by 488 bytes from 815,472 to 815,960

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +1.3% +3.29Ki  +1.3% +3.29Ki    __TEXT,__text
  +3.7%    +736  +3.7%    +736    __DATA,__cfstring
  +0.3%    +384  +0.3%    +384    Symbol Table
  +1.6%    +299  +1.6%    +299    __TEXT,__cstring
  +0.2%     +96  +0.2%     +96    __DATA,__objc_const
  +0.0%     +72  +0.0%     +72    String Table
  +0.1%     +38  +0.1%     +38    __TEXT,__objc_methname
  +0.3%     +24  +0.3%     +24    Export Info
  +0.4%     +24  +0.4%     +24    __DATA,__objc_selrefs
  +0.4%      +8  +0.4%      +8    Function Start Addresses
  [ = ]       0  +0.1%      +8    __DATA,__bss
  +0.4%      +4  +0.4%      +4    __DATA,__objc_ivar
  -0.9%     -32  -0.9%     -32    __DATA,__const
  [ = ]       0 -13.1%    -488    [__LINKEDIT]
  -9.3%    -828  -5.4%    -836    [__DATA]
 -15.4% -3.61Ki -15.4% -3.61Ki    [__TEXT]
  +0.1%    +488  [ = ]       0    TOTAL

Generated by 🚫 Danger

@nickdowell nickdowell marked this pull request as ready for review July 5, 2022 10:44
@nickdowell nickdowell requested a review from kstenerud July 5, 2022 10:44
@nickdowell nickdowell merged commit da93add into next Jul 5, 2022
@nickdowell nickdowell deleted the nickdowell/telemetry-usage branch July 5, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants