Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-8614] Prevent reporting of OOMs on simulators #1421

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

nickdowell
Copy link
Contributor

Goal

Prevent reporting of (false positive) OOMs on simulators.

Apps running in the simulator are not killed by the system in response to memory warnings. OOMs reported from the simulator are therefore most likely to be due to the app being killed by Xcode when running without a debugger attached, and it does not make sense to report these.

Changeset

BSG_HAVE_OOM_DETECTION now evaluates to 0 when building for simulators.

Testing

Verified using local test app. E2E tests on CI verify that OOM reporting still works on real devices.

@github-actions
Copy link

1 Warning
⚠️ This PR modifies BSGRunContext.h but does not change BSGRUNCONTEXT_VERSION

Bugsnag.framework binary size did not change - 815,472 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@nickdowell nickdowell merged commit b1e5a40 into next Jun 30, 2022
@nickdowell nickdowell deleted the nickdowell/no-ooms-on-simulator branch June 30, 2022 08:18
@nickdowell nickdowell mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants