Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-8476] Allow internal error reporting to be disabled #1375

Merged
merged 2 commits into from
May 18, 2022

Conversation

nickdowell
Copy link
Contributor

Goal

Allow internal error reporting to be disabled.

Changeset

Adds telemetry property to BugsnagConfiguration which contains a single "internal errors" option, enabled by default.

Skips initialization of BSGInternalErrorReporter if option is disabled.

Testing

Adds E2E scenario to verify that internal errors are not sent when option is disabled.

@github-actions
Copy link

Bugsnag.framework binary size increased by 408 bytes from 819,856 to 820,264

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +232  +0.1%    +232    String Table
  +0.1%    +192  +0.1%    +192    Symbol Table
  +0.0%    +112  +0.0%    +112    __TEXT,__text
  +0.2%     +96  +0.2%     +96    __DATA,__objc_const
  +0.2%     +52  +0.2%     +52    __TEXT,__objc_methname
  +0.2%     +16  +0.2%     +16    __DATA,__objc_selrefs
  +0.4%      +8  +0.4%      +8    Function Start Addresses
  +0.4%      +4  +0.4%      +4    __DATA,__objc_ivar
  +0.1%      +1  +0.1%      +1    __TEXT,__objc_classname
  -0.3%     -24  -0.3%     -24    Export Info
  -1.5%    -116  -0.8%    -116    [__DATA]
  -1.1%    -165  -1.1%    -165    [__TEXT]
  [ = ]       0  -2.6%    -408    [__LINKEDIT]
  +0.0%    +408  [ = ]       0    TOTAL

Generated by 🚫 Danger

@nickdowell nickdowell force-pushed the nickdowell/disable-internal-errors branch from 01f18a1 to ff095a3 Compare May 18, 2022 12:46
@nickdowell nickdowell requested a review from kstenerud May 18, 2022 12:48
@nickdowell nickdowell changed the title [ROAD-1488] Allow internal error reporting to be disabled [PLAT-8476] Allow internal error reporting to be disabled May 18, 2022
@nickdowell nickdowell merged commit adb01d0 into next May 18, 2022
@nickdowell nickdowell deleted the nickdowell/disable-internal-errors branch May 18, 2022 13:55
@nickdowell nickdowell mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants