[PLAT-8386] Fix test flake in in LastRunInfoScenario #1345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix an occasional test failure in
features/last_run_info.feature:6
/LastRunInfoScenario
.Sometimes one of the
And I wait to receive an error
steps would fail because the fixture crashed before the previous run's payload was sent.This scenario relied on
config.sendLaunchCrashesSynchronously
for payloads to be sent before crashing the fixture, but in some cases due to a slow network connection 2 seconds (which is as long asBugsnag.start()
will wait) is not enough.Changeset
Ensures crash reports have been sent before triggering another crash.
Testing
Was unable to reproduce this artifically / verify the fix.
Maze Runner's
I set the response delay to {int} milliseconds
step does not reproduce the failure because it does not prevent the request being fully received by the server within the 2 seconds.