Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-8386] Fix test flake in in LastRunInfoScenario #1345

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

nickdowell
Copy link
Contributor

Goal

Fix an occasional test failure in features/last_run_info.feature:6 / LastRunInfoScenario.

Sometimes one of the And I wait to receive an error steps would fail because the fixture crashed before the previous run's payload was sent.

This scenario relied on config.sendLaunchCrashesSynchronously for payloads to be sent before crashing the fixture, but in some cases due to a slow network connection 2 seconds (which is as long as Bugsnag.start() will wait) is not enough.

Changeset

Ensures crash reports have been sent before triggering another crash.

Testing

Was unable to reproduce this artifically / verify the fix.

Maze Runner's I set the response delay to {int} milliseconds step does not reproduce the failure because it does not prevent the request being fully received by the server within the 2 seconds.

@github-actions
Copy link

Bugsnag.framework binary size did not change - 852,504 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@nickdowell nickdowell merged commit fe25e21 into next Apr 25, 2022
@nickdowell nickdowell deleted the nickdowell/fix-last-run-info-scenario branch April 25, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants