Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing imports when not using clang modules #1284

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Add missing imports when not using clang modules #1284

merged 1 commit into from
Jan 19, 2022

Conversation

keith
Copy link
Contributor

@keith keith commented Jan 18, 2022

If CLANG_ENABLE_MODULES=NO these imports are missing leading to
compiler errors.

@keith
Add missing imports when not using clang modules
9aed5a1 
If `CLANG_ENABLE_MODULES=NO` these imports are missing leading to
compiler errors.
@nickdowell nickdowell changed the base branch from master to next January 19, 2022 08:22
nickdowell
nickdowell approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@nickdowell nickdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keith!

nickdowell added a commit that referenced this pull request Jan 19, 2022
@nickdowell
Merge pull request #1284 from keith/ks/add-missing-imports-when-not-u…
c78669a 
…sing-clang-modules

# Conflicts:
#	CHANGELOG.md
@nickdowell nickdowell merged commit 9aed5a1 into bugsnag:next Jan 19, 2022
@nickdowell nickdowell mentioned this pull request Jan 19, 2022
Merged
@luke-belton
Copy link
Member

hey @keith - thanks again for this. We've released this in v6.16.1 of bugsnag-cocoa 🎉

@luke-belton luke-belton added the released This feature/bug fix has been released label Jan 19, 2022
@keith
Copy link
Contributor Author

keith commented Jan 19, 2022

Thank you!

@keith keith deleted the ks/add-missing-imports-when-not-using-clang-modules branch January 19, 2022 16:56
@imjoehaines imjoehaines mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickdowell nickdowell nickdowell approved these changes

Assignees
No one assigned
Labels
released This feature/bug fix has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keith @luke-belton @nickdowell