[PLAT-7432] Fix crash in -[BSGURLSessionTracingProxy forwardInvocation:] #1208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix a crash in
-[NSInvocation selector]
when called from-[BSGURLSessionTracingProxy forwardInvocation:]
for some (malformed?) invocations that have appear to have too few arguments.Changeset
The crash is avoided by simplifying the implementation of
forwardInvocation:
and removing the call to-[NSInvocation selector]
- which is possible becauseBSGURLSessionTracingProxy
now implementsURLSession:task:didFinishCollectingMetrics:
Testing
Unit tests have been added to ensure the forwarding logic works as intended.
Unit tests now run on CI, which required some alteration of settings and code.